[MIRROR] Fixes Alien Hunter's Pounce Visuals #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes Alien Hunter's Pounce Visuals (#81322) ## About The Pull Request Currently on live, when an alien hunter goes for a pounce, once the pounce is completed the hunter will rise quite a distance slowly from the floor as setting body_position_pixel_y_offset now is done with animation as opposed to being instant. This looked extremely stupid, so I went and fixed it. Initially, I was going to add some form of trait to cancel out the smoothing effect from a shifting y offset, until I looked at the sprite for alien pouncing and realized it was 96x96 for no reason. For reference, 96x96 is the size of Bubblegum's sprites. So, I just made the sprites 48x32, got rid of the unused sprites (sentinel and drone both had pounce sprites but neither ever had that ability iirc) and adjusted some of the pounce ability's internal offset stuff to compensate and it looks perfectly fine now. Somehow made the image file larger by 243 bytes according to Github but I guess it is what it is. ## Why It's Good For The Game The alien hunter ascending from 2 tiles below where it actually was whenever it pounced was incredibly jarring. This fixes the problem. ## Changelog :cl: fix: Alien Hunter's pounce ability no longer has any weird offset issues once the pounce is completed. /:cl: * Fixes Alien Hunter's Pounce Visuals --------- Co-authored-by: IndieanaJones <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 8, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 7, 2024
* Maint Mania dust runtime fix (#82487) ## About The Pull Request This removes some dust from a space tile that was throwing stack_traces every time the Maint Mania map was loaded up. ## Why It's Good For The Game Less clutter while looking for an entirely unrelated runtime regarding deathmatch. ## Changelog :cl: Rhials fix: Sweeps a tile of dust off of the Maint Mania deathmatch map, which was causing errors. /:cl: * Maint Mania dust runtime fix --------- Co-authored-by: Rhials <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#829
Original PR: tgstation/tgstation#81322
About The Pull Request
Currently on live, when an alien hunter goes for a pounce, once the pounce is completed the hunter will rise quite a distance slowly from the floor as setting body_position_pixel_y_offset now is done with animation as opposed to being instant. This looked extremely stupid, so I went and fixed it. Initially, I was going to add some form of trait to cancel out the smoothing effect from a shifting y offset, until I looked at the sprite for alien pouncing and realized it was 96x96 for no reason. For reference, 96x96 is the size of Bubblegum's sprites.
So, I just made the sprites 48x32, got rid of the unused sprites (sentinel and drone both had pounce sprites but neither ever had that ability iirc) and adjusted some of the pounce ability's internal offset stuff to compensate and it looks perfectly fine now. Somehow made the image file larger by 243 bytes according to Github but I guess it is what it is.
Why It's Good For The Game
The alien hunter ascending from 2 tiles below where it actually was whenever it pounced was incredibly jarring. This fixes the problem.
Changelog
🆑 IndieanaJones
fix: Alien Hunter's pounce ability no longer has any weird offset issues once the pounce is completed.
/:cl: